Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change nhost url #1218

Closed
wants to merge 34 commits into from
Closed

Change nhost url #1218

wants to merge 34 commits into from

Conversation

Angra974
Copy link
Contributor

Description

Nhost has changed their backend url.
So we need to switch to the new one even if we have gained with the intervention of #atapas some time to use the ancient url.

Fixes #1217

Type of change

changed url in .env.development file

change in src/common/const/nhost.js

Not util for this problem but done it because usually, we will not need to change value in the source code for
environment variable to works in the application so we can just set it up in the .env.development file or others to have the job done.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (@atapas take care of this part )

How Has This Been Tested?

Locally as the url is from a domain outside the application it will not work if the url was not ok.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-play ❌ Failed (Inspect) Jul 18, 2023 6:46am

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for reactplayio failed.

Name Link
🔨 Latest commit bc305ee
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/64b6354cb406120008b6a01c

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@Angra974 Angra974 closed this Jul 18, 2023
@Angra974 Angra974 deleted the change_nhost_url branch July 18, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: Nhost backend url will not be valid since today
1 participant