[Bug Fix] : fix cypress test fail #866

[Roshan-Horo]

Fixed #866

Description

This PR is related to issue caused by running Cypress on Github Actions.

There are two issue related to that :

1. Timeout Issue while running Github Actions ( push, pull_request) : The main issue here is cypress is waiting of default 30s or max 90s around to start development server. But the server not started yet. ( It takes around 180s to start )

That's why cypress exit and test got failed.

2. Maybe some test case itself got failed : This is related to Issue 🐛 [Bug report]: Fix the Cypress test fail issue #866, There are two observation that I find by running test locally

• when we test manually through cypress:open : we got all test passed

• But, when we test through cypress:run : 1 test got failed ( Tweet section )

Fixes # (issue)

1. Fixing the 1st Issue with :

SHORT TERM SOLUTION : Increase the waiting time period by 180 s , I tested by running github actions locally and It takes around 180s to start the server and cypress will run it's tests.

LONG TERM SOLUTION : Reduce the server starting time. ( I think Issue #578 ( Migrate from CRA to VITE ) solves this problem.

Without wait-on-timeout

With wait-on-timeout: 180

2. Test case 'Twitter Section ...' got failed : Running locally with cypress:run got failed but running with cypress:open and with github actions it got all tests passed. so, we can leave it there, if it's causing other problems then we can take this.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Through running Github Actions locally.

Reference

• Cypress timeout issue : Cypress always times out on Github Actions [Help Request] cypress-io/github-action#534
• wait-on-timeout example : https://github.com/cypress-io/github-action/blob/master/.github/workflows/example-wait-on.yml
• Running github actions locally : https://github.com/nektos/act

[vercel]

@Roshan-Horo is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-play	🔄 Building (Inspect)	Visit Preview		Jun 29, 2023 9:57am

[swapn652]

So, this is why so many PRs have failed the checks.

[github-actions]

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

[atapas]

@Roshan-Horo I need the issue number to merge.

[netlify]

✅ Deploy Preview for reactplayio ready!

Name	Link
🔨 Latest commit	7ac5c5a
🔍 Latest deploy log	https://app.netlify.com/sites/reactplayio/deploys/64a25c730df76500087c24b1
😎 Deploy Preview	https://deploy-preview-1112--reactplayio.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Roshan-Horo]

Hey @atapas, updated the issue no. in the PR description but the issue is in closed state.

[Angra974]

@atapas

@Roshan-Horo I need the issue number to merge.

Consider to add some config in cypress :
"defaultCommandTimeout": 6000,
"execTimeout": 60000,
"pageLoadTimeout": 600000,
"requestTimeout": 1500000,
"responseTimeout": 1500000,

as the problem is more related to a slow network and the response time than the application itself ( slow by itself nevertheless ) .

[atapas]

@atapas

@Roshan-Horo I need the issue number to merge.

Consider to add some config in cypress : "defaultCommandTimeout": 6000, "execTimeout": 60000, "pageLoadTimeout": 600000, "requestTimeout": 1500000, "responseTimeout": 1500000,

as the problem is more related to a slow network and the response time than the application itself ( slow by itself nevertheless ) .

@Roshan-Horo have you checked this?

[github-actions]

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!