Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify usage by updating to new default loop #54

Merged
merged 1 commit into from
Jul 11, 2021
Merged

Simplify usage by updating to new default loop #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions theme/homepage.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,7 @@
<div class="welcome__example">
{% markdown %}
```php
$loop = React\EventLoop\Factory::create();

$server = new React\Http\Server($loop, function (Psr\Http\Message\ServerRequestInterface $request) {
$server = new React\Http\Server(function (Psr\Http\Message\ServerRequestInterface $request) {
return new React\Http\Message\Response(
200,
array(
Expand All @@ -53,15 +51,13 @@ $server = new React\Http\Server($loop, function (Psr\Http\Message\ServerRequestI
);
});

$socket = new React\Socket\Server(8080, $loop);
$socket = new React\Socket\Server('127.0.0.1:8080');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well make it listen on all IP's

Suggested change
$socket = new React\Socket\Server('127.0.0.1:8080');
$socket = new React\Socket\Server('0.0.0.0:8080');

Copy link
Member Author

@clue clue Jul 10, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong preference here tbh. My change doesn't change this example at all, as localhost is also the default when only specifying the port, but it's somewhat more obvious this way.

I think recommending localhost listen address as a starting point is a more safe. Exposing this to the public internet requires only slightly more effort, but this is where things start to highly depend on use case / setup anyway, such as reverse proxy etc.. Additionally, the localhost address can also be used as is in URLs, which might make getting started slightly easier. WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but IMHO we could better educate what values are often used in production. Any machine you startup should have a firewall enabled by default. I agree that it's safer, but we should also guide our users from start to production with our project and these little things help.

$server->listen($socket);

echo "Server running at http://127.0.0.1:8080\n";

$loop->run();
echo "Server running at http://127.0.0.1:8080" . PHP_EOL;
```
{% endmarkdown %}
<p class="center">This simple web server written in ReactPHP responds with "Hello World" for every request.</p>
<p class="center">This simple web server written in ReactPHP responds with "Hello World!" for every request.</p>
</div>
</div>
</div>
Expand Down