Obey strict method and event semantics for closed and piped streams #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsor
approved these changes
Mar 7, 2017
tests/ThroughStreamTest.php
Outdated
| @@ -63,6 +63,53 @@ public function endShouldWriteDataBeforeClosing() | |||
| } | |||
|
|
|||
| /** @test */ | |||
| public function endTwiceShouldOnleEmitOnce() | |||
WyriHaximus
approved these changes
Mar 7, 2017
|
Thanks for spotting this, typo fixed and changes squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #72 and #73 and makes sure all methods obey strict method and event semantics for some of the less obvious cases. This project now has 100% test coverage 🎉