Consistent end event semantics (EOF) #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsor
approved these changes
Mar 3, 2017
clue
commented
Mar 4, 2017
src/BufferedSink.php
Outdated
|
|
||
| // reject because this is not an end() and clear buffer | ||
| $this->buffer = ''; | ||
| $this->deferred->reject(new \RuntimeException('Closed without ending')); |
There was a problem hiding this comment.
Let me revert this change to keep this diff smaller 👎
I'd rather not change the BufferedSink at all, it will likely be removed via #45 anyway.
|
Updated to only affect |
WyriHaximus
approved these changes
Mar 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An
endevent will (only) be emitted when the stream/connection reached EOF (end of file or other side closes the connection)This is potentially a BC break for anybody who relied on the existing inconsistent(!) behavior, where the
endwas usually(!) emitted right before acloseevent. Consumers should use the unchangedcloseevent in this case.Closes #59