Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves test coverage #66

Merged
merged 2 commits into from
Feb 15, 2017
Merged

Improves test coverage #66

merged 2 commits into from
Feb 15, 2017

Conversation

nawarian
Copy link
Contributor

This PR makes React\Stream\Stream 100% covered with unit tests.

clue
clue approved these changes Feb 15, 2017
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this, changes LGTM! 👍

@WyriHaximus WyriHaximus merged commit c6665e7 into reactphp:master Feb 15, 2017
@nawarian nawarian deleted the improve-test-coverage branch February 15, 2017 10:40
@clue clue added this to the v0.5.0 milestone Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clue clue clue approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
easy pick maintenance
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nawarian @WyriHaximus @clue