Avoid unneeded syscall when creating non-blocking DuplexResourceStream
#164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR removes an unneeded syscall when creating a non-blocking
DuplexResourceStream
. The current logic separates the readable and writable side and accordingly sets non-blocking mode twice even if it references the exact same file descriptor. This changeset suggests avoiding the first call for theDuplexResourceStream
, as the non-blocking mode will always be set for its writable side through theWritableResourceStream
anyway.This change does not affect performance in any noticeable way, but helps avoid unneeded syscalls in an attempt to ease debugging and improve overall performance (see reactphp/http#455). For a single HTTP request, this means the following syscalls can be eliminated:
This changeset only removes some internal logic and does not affect the public API, so it should be safe to apply. The test suite confirms this has 100% code coverage.
Refs reactphp/http#455 and reactphp/socket#292