Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward compatibility with PHPUnit 6 #122

Merged
merged 2 commits into from
Nov 18, 2017
Merged

Forward compatibility with PHPUnit 6 #122

merged 2 commits into from
Nov 18, 2017

Conversation

carusogabriel
Copy link
Contributor

I use the PHPUnit\Framework\TestCase notation instead of PHPUnit_Framework_TestCase while extending our TestCase. This will help us migrate to PHPUnit 6, that no longer support snake case class names.

I just need to bump PHPUnit version to ^4.8.35 and ^5.7, that support this namespace.

Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Makes perfect sense to make, paves the road to PHPUnit 6 and beyond

Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for you digging into this and filing this PR! The changes LGTM, does it make sense to you to add support for PHPUnit 6 as part of this PR? :shipit:

@clue clue added this to the v0.7.5 milestone Nov 17, 2017
@carusogabriel
Copy link
Contributor Author

@clue Done. Added PHPUnit 6 support.

@clue clue changed the title Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase Forward compatibility with PHPUnit 6 Nov 18, 2017
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick update, changes LGTM! :shipit: 👍

@jsor jsor merged commit 97269c1 into reactphp:master Nov 18, 2017
@carusogabriel carusogabriel deleted the phpunit branch November 18, 2017 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants