Improve error reporting to include both IPv6 & IPv4 errors (happy eyeballs) #233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset improves error reporting for failed connection attempts using happy eyeballs to always include the last error message for both IPv6 and IPv4 protocol families. The rationale for this is that both families commonly fail for very different reasons (broken IPv6 connectivity etc.). If both families report the same error, the message will only include a single message:
Builds on top of #232, #231, #230, #224 and #225
Refs #171 and others