Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip mocking DNS resolver (warning) #207

Closed
clue opened this issue Jul 11, 2019 · 0 comments · Fixed by #208
Closed

Skip mocking DNS resolver (warning) #207

clue opened this issue Jul 11, 2019 · 0 comments · Fixed by #208
Labels
easy pick help wanted maintenance
Milestone
v1.4.0

Comments

@clue
Copy link
Member

clue commented Jul 11, 2019

don't mock what you don't own

Our test suite currently tries to create mock of React\Dns\Resolver\Resolver which is now marked final as of reactphp/dns#134. This leads to a "warning" as of PHP 5.6 and a build error in older PHP/PHPUnit versions. We should update the test suite of this component to no longer try to mock this class. Any input / PR is appreciated 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy pick help wanted maintenance
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

Accept DNS ResolverInterface and fix failing test suite clue-labs/socket
1 participant
@clue