Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Http] Implement full HTTP/1.1 spec #3

Closed
igorw opened this issue May 10, 2012 · 5 comments
Closed

[Http] Implement full HTTP/1.1 spec #3

igorw opened this issue May 10, 2012 · 5 comments

Comments

@igorw
Copy link
Contributor

igorw commented May 10, 2012

Some todos:

  • delimit requests by empty body, content-length or chunked encoding (as defined by the RFC)
  • keepalive
  • 100-continue handling (could be improved by adding a separate event for that header)
  • pipelining
  • multipart parsing (inspiration)

We also need to decide how to handle encoding of outgoing data. There are different use cases for modifying the response, some of which may require buffering: websockets, gzip compression, chunked encoding.

igorw pushed a commit that referenced this issue Jul 8, 2013
Retain reference to lambda to prevent it from being gc'd early
@andig
Copy link

andig commented Mar 11, 2015

Is there any progress? I understand without this solved there is no simple reading POST requests?

@onigoetz
Copy link

I started work on reactphp/http#13 and that adds the ability to read POST request parameters

But don't know how to finalize the part with file uploads. we should implement each upload a a stream, but I don't know how to do it.

If you want to give a hand, you're welcome to do so.

@andig
Copy link

andig commented Mar 20, 2015

Imho simple post handling is a very necessary first step. Why not skip multipart for now?

@onigoetz
Copy link

Actually, POST is also sent through multipart. An implementation of POST without multipart would be incomplete.

@clue
Copy link
Member

clue commented Feb 8, 2017

See reactphp/http#39 and reactphp/http#96

@clue clue closed this as completed Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants