-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove race() #81
Remove race() #81
Conversation
Closes #57
Let me quote from the linked issue:
I'm currently undecided, but I'm okay with either. |
A little bit more context: Our current implementation is not compatible with the ES6 specification because it does not return a forever pending promise if an empty array is given (currently, it returns a resolved promises with no value). The discussion in #57 has been whether to remove it completely or make it ES6 compliant. Given that |
IMHO consistency with ES6 makes sense, but it's not really a necessity because interoperability doesn't really apply across language boundaries anyway. Hence my vote to first document the current behavior and how this may differ from other implementations (afaict there's no mention of ES6 promises in the docs in the first place?). |
@clue Consistency with ES6 in this case does not mean being consistent just for the sake of it but just to behave correctly. Our documentation states:
So, the current implementation simply does not behave how we document it. It is arguable whether the return value should be a forever pending promise or if we should return an error (like we do with |
I've opened an alternative PR which changes the behavior to return a forever pending promise: #83 |
Closed by #83 |
See #57 for the discussion.
Closes #57