Add PHP 8.4 to the CI and fix implicit nullable types #259
Conversation
Fixes all issues that emits a deprecation notice on PHP 8.4. See: - [RFC](https://wiki.php.net/rfc/deprecate-implicitly-nullable-types) - [PHP 8.4: Implicitly nullable parameter declarations deprecated](https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated)
|
(I'm now looking at why the job fails on 8.4) |
|
Now green on PHP 8.4. All it needs is the latest version of phpunit (not tagged yet) |
There was a problem hiding this comment.
@nicolas-grekas Thanks for opening this pull request 👍
Seems like a reasonable change to me. I originally said that it makes sense to wait for the other additions and changes for PHP 8.4, but after the conversation with @Seldaek in #258, I also agree that it makes sense to create compatibility with the upcoming PHP version now (especially to avoid any deprecation warnings).
@clue looked into supporting the latest PHPUnit versions as well, but we'll probably address this in a later pull request
Also big thank you to @Ayesh for opening #258 which contained most of the changes in here 👍
|
Great, thanks for listening to feedback :) |
|
Is there any expected date for new release compatible with fixed nullable types? |
|
I opened a new pull request in #260 for this. The ongoing development in PHP 8.4 is currently breaking our test suite (changed stack trace -> failing I created a new proposal, which follows the original pull request from @Ayesh in #258. I tried to reopen the old PR, but couldn't do so as the created fork was already removed. Once #260 is approved and merged, it will automatically close this PR here as well. Sorry for the back and forth, but I think we've come to a viable solution now. Thanks for everybody who contributed to the discussion 👍 |
Cherry-picking from #258