-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support intersection types (PHP 8.1+ / ported from v2 to v3) #209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bzikarsky Thank you for taking over and porting this also to Promise v3! 👍
The changes LGTM, but I've noticed some potential to simplify this given we can finally(!) rely on more recent PHP features (#149). Can you look into this?
@bzikarsky I can indeed see the same error on PHP 8.1 (#199) and you're right that this seems to be unrelated to this PR, so perhaps better file this as a separate PR? |
Thanks @clue for going over it. Those 7.1 related simplifications make sense and I can also supply that extra fix in a separate PR. It may have to wait until Monday though - depending on what my family is up to over the weekend. 🙂 |
02ed10a
to
5189eb6
Compare
Improvements are in. 🙂
PR is at #210. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bzikarsky Thanks for the update, changes LGTM, keep it up!
See #195 for details.
Unrelated: I fixed an E_DEPRECATED on 8.1 in
RejectedPromiseTest
(Deprecated: Exception::__construct(): Passing null to parameter #1 ($message) of type string is deprecated in /code/tests/Internal/RejectedPromiseTest.php on line 40
) - Are you fine with adding this in an additional commit to the PR or do you want to have a separate PR (and more rebase action)?