Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throwable type improvements #141

Merged
merged 4 commits into from
May 9, 2019
Merged

Throwable type improvements #141

merged 4 commits into from
May 9, 2019

Conversation

jsor
Copy link
Member

@jsor jsor commented May 9, 2019

Follow-up for #138.

  • Improve _checkTypehint()
  • Fix variable name in docblock description and @param declaration
  • Remove FunctionalRejectTest as it only tests non-throwable rejection reasons
  • Add missing Throwable parameter type-declarations to rejection functions

@WyriHaximus WyriHaximus added this to the v3.0.0 milestone May 9, 2019
@WyriHaximus WyriHaximus requested review from WyriHaximus and clue May 9, 2019 09:52
@clue clue added the BC break label May 9, 2019
@clue clue merged commit d3712e4 into reactphp:master May 9, 2019
@jsor jsor deleted the throwable-type-improvements branch May 9, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clue clue clue approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
BC break
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jsor @WyriHaximus @clue