Use Promise v3 template types #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonFrings
approved these changes
Jul 20, 2023
This was referenced Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple changeset adds proper Promise v3 template types to describe API arguments and return values. The change is pretty straightforward, as most of the work was done upstream and in previous PRs linked below.
Note that this project doesn't currently use PHPStan itself, so this is a bit harder to reproduce on its own. I've tested this in a number of downstream projects and it appears this is the minimal changeset required to make downstream projects work that depend on these functions. I'll link relevant PRs against this one for reference.
I'd vote to get this in as is for now to make sure we unblock any downstream projects. Note that this doesn't preclude how and/or whether we're going to integrate PHPStan into pre-v3 components like this one as already discussed in reactphp/async#77.
Builds on top of reactphp/promise#247, #64 and #63