Chore: Update for 3.x #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bpolaszek Thanks for looking into this, but as you already wrote above, we have no plans for a ReactPHP PromiseStream v3 yet. I opened #40 last week in order to create a place to discuss the next steps for reactphp/promise-stream with ReactPHP v3, so I don't think there's currently much to do here. I'll close this for know, but we can revisit this topic if we're certain that PromiseStream will get a v3. FYI: I also created similar tickets in reactphp/promise-timer, reactphp/datagram & reactphp/child-process discussing the same matter. Let's first try to focus on the components that have their v3 roadmaps already released 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: Sorry, didn't notice #40
PR likely to be useless, just cleaning up :-)