Emit error event for invalid requests (instead of crashing) #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out this is a duplicate of #65, I guess I should probably have checked my mails first :) |
|
Yeah no problem, was watching the stream and decided to fix it right away 👍 . Thanks for putting in this PR non the less 👍 |
|
@clue The fixes in both are nearly identical, the only main difference are not removing listeners in your PR vs removing listeners in mine. Lets pick one? 😄 Personally I'm in favor of mine because it stops listening, catches more exceptions (shouldn't matter though). How ever yours also emits |
|
I agree, yours has been there first, which makes mine a duplicate :-) Now let's look into getting #65 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.