Code

Streaming request body parsing#41

Code

Closed

WyriHaximus wants to merge 66 commits intomasterreactphp/http:masterfrom streaming-multipartreactphp/http:streaming-multipartCopy head branch name to clipboard

+1,232-538

Commits

Commits on Oct 1, 2015

• All request bodies now come in streaming

  WyriHaximus

  committed
  b3e9253

• Moved parsers to their own namespace

  WyriHaximus

  committed
  e1b0d03

• File object representing uploaded files

  WyriHaximus

  committed
  dca940d

• Cleaned up old test code I've forgotten to remove

  WyriHaximus

  committed
  816d1c6

Commits on Oct 28, 2015

• https://github.com/reactphp/http/issues/44#issuecomment-151941120

  WyriHaximus

  committed
  9eb1a93

Commits on Mar 19, 2016

• End the stream when not streaming

  WyriHaximus

  committed
  9bb6116

• Properly trim off the file contents

  WyriHaximus

  committed
  41eaa92

• Make sure extra headers are ignored

  WyriHaximus

  committed
  2860f10

Commits on Mar 20, 2016

• Emit the post vars instead of setting them from the FormUrlencoded parser

  WyriHaximus

  committed
  64446d1

Commits on Mar 21, 2016

• FormParserFactory

  WyriHaximus

  committed
  25f4718

• Changed both parsers to work with only the request

  WyriHaximus

  committed
  db68230

Commits on Mar 22, 2016

• Revert old behavior and set request (partial) body

  WyriHaximus

  committed
  ab99c8f

• Updated tests and removed multipart and urlencoded tests

  WyriHaximus

  committed
  20682f6

Commits on Mar 23, 2016

• Replaced array_key_exists with isset

  WyriHaximus

  committed
  1501ab8

• Don't exactly match content type for FormUrlencoded in case extra data is passed in the header

  WyriHaximus

  committed
  8c0b93e

• Fetch content type and force it's contents to lowercase so we only have to do that once

  WyriHaximus

  committed
  a09ec5f

• Moved initial content length header detection to the constructor

  WyriHaximus

  committed
  e4925f9

• Removed post property from Request

  WyriHaximus

  committed
  085e01d

• Remove body property from Request, restoring it to the state it was in with 0.4.1

  WyriHaximus

  committed
  92b6a73

Commits on Mar 24, 2016

• Case insensitive multipart chunk headers

  WyriHaximus

  committed
  6500579

• Headers are made case insensitive after getHeaders

  WyriHaximus

  committed
  d525755

• Removed un-used imports

  WyriHaximus

  committed
  1755230

Commits on Apr 14, 2016

• NoBody object return from the form parser factory in case we don't have anything to parse but we do return an object in that case

  WyriHaximus

  committed
  578f288

Commits on Apr 15, 2016

• Renamed to GPL as we are going to replace it

  WyriHaximus

  committed
  78e2ed0

Commits on Apr 17, 2016

• Bare skeleton of the new Multipart parser

  WyriHaximus

  committed
  3b0de3a

• Parser interface

  WyriHaximus

  committed
  e9bac7c

• Detect boundary if none is present in headers; https://github.com/reactphp/http/pull/41/files#r57567088

  WyriHaximus

  committed
  261e850

Commits on Apr 18, 2016

• Pre set boundary ending and size

  WyriHaximus

  committed
  4de83e1

Commits on Apr 19, 2016

• Parse header and post chunks

  WyriHaximus

  committed
  3c76b9f

Commits on Apr 23, 2016

• Return NoBody parser in case the factory can't find out which parser to use

  WyriHaximus

  committed
  64ff430

• Added file support to the multipart parser

  WyriHaximus

  committed
  4b86553

• Removed GPL multipart parser

  WyriHaximus

  committed
  9b959d7

• Added close event forwarding

  WyriHaximus

  committed
  2928193

• Emit events on parser instead of request

  WyriHaximus

  committed
  8c34c92

Commits on Apr 24, 2016

• Typo, $this->request doesn't exists

  WyriHaximus

  committed
  598d50f

Commits on May 2, 2016

• Deferred stream that waits until the request emits end

  WyriHaximus

  committed
  44f2517

• Emit end (not close) when the full body has been parsed

  WyriHaximus

  committed
  eb72ded

• Missed an emit close

  WyriHaximus

  committed
  621ee71

Commits on May 5, 2016

• Detect body end instead of waiting for end event

  WyriHaximus

  committed
  87cf49e

• Added isDone method to parsers for those cases where an end would be emitted within the constructor

  WyriHaximus

  committed
  1384f81

Commits on May 10, 2016

• Dropped the done trait

  WyriHaximus

  committed
  c68bb16

• Introducing the RawBody for when we can't determin the content type but have a content length

  WyriHaximus

  committed
  b80c745

• Section in the readme on FormParserFactory and DeferredStream

  WyriHaximus

  committed
  78b38ca

Commits on May 17, 2016

• Typo: quest => request

  WyriHaximus

  committed
  b888423

Commits on Jul 3, 2016

• Correctly handle file names with colons in them

  WyriHaximus

  committed
  dbc2356

• Ensure we always have content type

  WyriHaximus

  committed
  74c2150

• Ensure correct multipart boundary handling

  WyriHaximus

  committed
  29f50ed

• Slice off two characters at the beginning of detected boundaries

  WyriHaximus

  committed
  29a9e5d

• Merge branch 'master' into streaming-multipart

  Show description for cabf9d9
  WyriHaximus

  committed
  cabf9d9

• Resolved issues that come up when merging master into this branch

  WyriHaximus

  committed
  3794e36

Commits on Jul 7, 2016

• Renamed File::getType to File::getContentType as a result of: #41 (comment)

  WyriHaximus

  committed
  92f347b

• Merge branch 'master' into streaming-multipart

  Show description for d35937f
  WyriHaximus

  committed
  d35937f

• Removed branch alias after merge

  WyriHaximus

  committed
  7c83595

• Corrected promise targetting: #41 (comment)

  WyriHaximus

  committed
  b2fddd2

• Simplefied content type and length detection: #41 (comment)

  WyriHaximus

  committed
  77fd1b2

• Forgot to replace || with &&

  WyriHaximus

  committed
  7d75b00

Commits on Jul 8, 2016

• Renamed Parser namespace to BodyParser and also moved the FormParserFactory: #41 (comment)

  WyriHaximus

  committed
  7873ca0

• Renamed BodyParser to StreamingBodyParser to make it more explicit what those parsers are doing

  WyriHaximus

  committed
  1676b33

• Don't attach fieldname to File object, emit it with file instead: #41 (comment)

  WyriHaximus

  committed
  339416d

• Addressed @clue's concerns for the mixing concerns, by creating ContentLengthBufferedSink and handling the buffering until limit is reached in there: #41 (comment)

  WyriHaximus

  committed
  32edca3

Commits on Aug 3, 2016

• Appended Parser to all streaming body parsers as suggested by @jsor at #41 (comment)

  WyriHaximus

  committed
  57bdc26

• Renamed DeferredStream to BufferedSink and modled it more like react/stream's BufferedSink as suggested by @jsor at #41 (comment)

  WyriHaximus

  committed
  ae172a5

• Renamed StreamingParserInterface to ParserInterface as suggested by @jsor at #41 (comment)

  WyriHaximus

  committed
  359781c

• Readme clarifications (suggested by @jsor)

  WyriHaximus

  committed
  f045fc4

Commits on Sep 6, 2016

• Catch the case where no content-type header is send

  WyriHaximus

  committed
  abb4ca0

Commits on Sep 7, 2016

• Deal with an edge case where a zero length will never fulfill the promise

  WyriHaximus

  committed
  d4cef86