Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce using PSR-7 HTTP Status code constants #406

Closed
wants to merge 1 commit into from
Closed

Introduce using PSR-7 HTTP Status code constants #406

wants to merge 1 commit into from

Conversation

WyriHaximus
Copy link
Member

@WyriHaximus WyriHaximus commented Apr 12, 2021

Introducing using these constants makes it easier to identify a
specific HTTP status used in our code. And for our users to use
readable status codes in their own code.

@WyriHaximus WyriHaximus added this to the v1.4.0 milestone Apr 12, 2021
@WyriHaximus WyriHaximus requested review from jsor and clue April 12, 2021 21:23
@jsor
Copy link
Member

jsor commented Apr 20, 2021

Would it make sense to use constants from Fig\Http\Message\StatusCodeInterface?

@WyriHaximus
Copy link
Member Author

@jsor How did I not know those are out there?! Updating the PR now

@WyriHaximus WyriHaximus changed the title Introduce HTTP Status code constants Introduce using PSR-7 HTTP Status code constants Apr 21, 2021
Introducing using these constants makes it easier to identify a
specific HTTP status used in our code. And for our users to use
readable status codes in their own code.
@clue clue modified the milestones: v1.4.0, v1.5.0 Jul 10, 2021
@clue clue removed this from the v1.5.0 milestone Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants