Add the event loop as required constructor argument #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now we won't use it just yet. But this will prepare our API for future features like keep alive connections, dead connection clean up etc. Even though we won't use it in the next release, it will put it in the API so we don't have to break it again when we add features that require the event loop. As a result of this requirement the event loop has been added as a dependency, and the socket and stream packages have been bumped to their stable version.
clue
approved these changes
Jul 8, 2020
jsor
approved these changes
Jul 8, 2020
This was referenced Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now we won't use it just yet. But this will prepare our API for
future features like keep alive connections, dead connection clean up
etc. Even though we won't use it in the next release, it will put it in
the API so we don't have to break it again when we add features that
require the event loop.