Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unneeded warning when decoding invalid data on PHP 7.4 #357

Merged
merged 1 commit into from
Jan 12, 2020
Merged

Avoid unneeded warning when decoding invalid data on PHP 7.4 #357

merged 1 commit into from
Jan 12, 2020

Conversation

WyriHaximus
Copy link
Member

@WyriHaximus WyriHaximus commented Jan 11, 2020 •
edited
Loading

Supersedes / Closes #356
Refs: reactphp/http-client#150

@WyriHaximus WyriHaximus added this to the v0.8.6 milestone Jan 11, 2020
@WyriHaximus WyriHaximus requested review from jsor and clue January 11, 2020 20:40
clue
clue reviewed Jan 12, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
clue
clue reviewed Jan 12, 2020
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPUnit 7+ reports a warning due to unsupported XML definition, otherwise LGTM 👍

.travis.yml Show resolved Hide resolved
@WyriHaximus WyriHaximus requested a review from clue January 12, 2020 12:36
@jsor jsor merged commit 248202e into reactphp:master Jan 12, 2020
@clue clue mentioned this pull request Aug 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clue clue clue approved these changes

@jsor jsor jsor approved these changes

Assignees
No one assigned
Labels
bug easy pick
Projects
None yet
Milestone
v0.8.6
Development

Successfully merging this pull request may close these issues.
3 participants
@WyriHaximus @jsor @clue