Internal refactoring to reuse single request parser for all requests #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clue unit tests are failing 😝 |
This changeset is in preparation for upcoming refactorings to move unrelated logic out of the parser class to prepare for persistent HTTP connections in follow-up PR. This changeset does not affect the public API and happens to improves performance slightly from around 9000 req/s to 9200 req/s on my machine (best of 5).
|
@WyriHaximus Updated to fix failing tests on legacy PHP |
|
@clue 👍 , will review tonight it's BBQ time! |
WyriHaximus
reviewed
Jun 16, 2019
WyriHaximus
approved these changes
Jun 16, 2019
jsor
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset is in preparation for upcoming refactorings to move
unrelated logic out of the parser class to prepare for persistent HTTP
connections in follow-up PR. This changeset does not affect the public
API and happens to improves performance slightly from around 9000 req/s
to 9200 req/s on my machine (best of 5).
We could expose the internal
RequestHeaderParseras input to theStreamingServerin order to solve #214, but I've decided against this change for now: Doing so would mean that we expose an otherwise@internalclass to the outside and thus make future changes to this class more difficult. The current changeset can be used as a base for future changes in this direction or some other option array as discussed in #214, but I'd rather leave this up for a future discussion.Builds on top of #345
Refs #39
Closes #241
Closes #242