Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note about limiting concurency in Server #335

Closed
wants to merge 1 commit into from

Conversation

woytam
Copy link

@woytam woytam commented Feb 20, 2019

For better understanding of not overwriting LimitConcurency in Server

Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start. maybe in a follow up PR review if we still show use Server in the example below

@andyvanee
Copy link

andyvanee commented Feb 22, 2019

I just encountered the same issue, as I was seeing no speedups after 4 concurrent requests. I was using the php docker container which uses the default ini settings of memory_limit = 128M and post_max_size = 8M which results in only 4 concurrent requests.

https://github.com/php/php-src/blob/master/php.ini-development#L401

Since I'm not really handling any uploads, I added the following .ini file, which boosted it to 4096 concurrent requests.

[PHP]

post_max_size = 8K
memory_limit = 256M

The note in the last paragraph of the Server section of the README does cover this already, but I was confused because the automatically added middleware was setting the upper bound.

I am curious about how to calculate a sensible number for concurrent requests and what the failure mode is if I push it too far? I guess I may have to do some more testing 😃

@clue
Copy link
Member

clue commented Apr 17, 2019

@woytam Thank you for filing this PR, I agree that it makes sense to add some documentation for this! 👍

I've just filed #342 to add some additional documentation for the concurrency limit and how to possibly avoid hitting this limit. Let me know what you think about this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants