Automatically close response stream once client connection closes #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
May 23, 2017
src/Server.php
Outdated
| // in particular this may only fire on a later read/write attempt | ||
| // because we stop/pause reading from the connection once the | ||
| // request has been processed. | ||
| $connection->on('close', function() use ($stream) { |
There was a problem hiding this comment.
Might as well write this as $connection->on('close', [$stream, 'close']);?
There was a problem hiding this comment.
I have updated the PR accordingly (have no strong opinion here) 👍
jsor
approved these changes
May 23, 2017
WyriHaximus
requested changes
May 23, 2017
| $socket->close(); | ||
| } | ||
|
|
||
| public function testStreamFromRequestHandlerWillBeClosedIfConnectionClosesWhileSendingBody() |
There was a problem hiding this comment.
There was a problem hiding this comment.
Fixed tests by increasing test timeouts 
| $socket->close(); | ||
| } | ||
|
|
||
| public function testStreamFromRequestHandlerWillBeClosedIfConnectionClosesButWillOnlyBeDetectedOnNextWrite() |
There was a problem hiding this comment.
This test also fails: https://travis-ci.org/reactphp/http/jobs/235196355#L228
There was a problem hiding this comment.
Fixed tests by increasing test timeouts
WyriHaximus
approved these changes
May 24, 2017
This was referenced Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #187
This is also a prerequisite for upcoming changes related to #98