Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated SocketClient with new Socket component to simplify CONNECT example #165

Merged
merged 1 commit into from
Apr 10, 2017
Merged

Replace deprecated SocketClient with new Socket component to simplify CONNECT example #165

merged 1 commit into from
Apr 10, 2017

Conversation

clue
Copy link
Member

@clue clue commented Apr 10, 2017

Builds on top of #161 which builds on top of #158

@clue clue added this to the v0.7.0 milestone Apr 10, 2017
@WyriHaximus WyriHaximus requested review from jsor and WyriHaximus April 10, 2017 14:38
WyriHaximus
WyriHaximus approved these changes Apr 10, 2017
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@WyriHaximus WyriHaximus merged commit f04febd into reactphp:master Apr 10, 2017
@clue clue deleted the socket branch April 10, 2017 20:50
@clue clue mentioned this pull request May 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@jsor jsor jsor approved these changes

Assignees
No one assigned
Labels
easy pick maintenance
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clue @jsor @WyriHaximus