Cast getSize() to string for Content-Length header #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, can you add a test for this? 👍 |
|
As discussed shortly with @clue on IRC, we may not need tests for this, so can be merged if no other issues are raised. |
jsor
approved these changes
Apr 7, 2017
clue
approved these changes
Apr 7, 2017
WyriHaximus
approved these changes
Apr 7, 2017
|
Awesome, thank you 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably fixes the issues with
Zend/Diactorosmentioned here #28 (comment). The exception is throwed sincegetSize()returnsintinstead ofstring(diactoros is very strict about this).This fixed my issues with
Diactorosresponses.