Merge pull request #150 from clue-labs/php7.4

Avoid unneeded warning when decoding invalid data on PHP 7.4
reactphp · Jan 13, 2020 · d753b10 · d753b10
2 parents e41c74d + c24f511
commit d753b10
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -8,6 +8,8 @@ php:
   - 7.0
   - 7.1
   - 7.2
+  - 7.3
+  - 7.4
   - nightly # ignore errors, see below
   - hhvm # ignore errors, see below
 

diff --git a/composer.json b/composer.json
@@ -14,7 +14,7 @@
     },
     "require-dev": {
         "clue/block-react": "^1.2",
-        "phpunit/phpunit": "^6.4 || ^5.7 || ^4.8.35",
+        "phpunit/phpunit": "^7.0 || ^6.4 || ^5.7 || ^4.8.35",
         "react/promise-stream": "^1.1"
     },
     "autoload": {

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -8,7 +8,6 @@
          convertWarningsToExceptions="true"
          processIsolation="false"
          stopOnFailure="false"
-         syntaxCheck="false"
          bootstrap="tests/bootstrap.php"
 >
     <testsuites>

diff --git a/src/ChunkedStreamDecoder.php b/src/ChunkedStreamDecoder.php
@@ -111,7 +111,7 @@ protected function iterateBuffer()
                 }
             }
             $this->nextChunkIsLength = false;
-            if (dechex(hexdec($lengthChunk)) !== strtolower($lengthChunk)) {
+            if (dechex(@hexdec($lengthChunk)) !== strtolower($lengthChunk)) {
                 $this->emit('error', array(
                     new Exception('Unable to validate "' . $lengthChunk . '" as chunk length header'),
                 ));
-Original file line number
+Diff line change
@@ Expand Up / @@ -8,6 +8,8 @@ php: @@
       - 7.0
       - 7.1
       - 7.2
+      - 7.3
+      - 7.4
       - nightly # ignore errors, see below
       - hhvm # ignore errors, see below
@@ Expand Down @@