-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Adapter::getContents & Adapter::putContents #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CharlotteDunois Thank you very much for this PR!
I agree that these methods make perfect sense from a consumer perspective and I agree that their naming makes sense in regards to the other methods. In the future, I would love to reconsider their naming in order to promote them more prominently
@clue If you have any specific naming in mind, speak your mind. If you can think of better names, it's better to change it now than later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@clue ping |
@clue Reminder. Also a reminder for buzz. |
@clue @jsor @WyriHaximus I've got a new idea on how to expose "non-standardizable" feature. As such I've updated the PR and would need to be looked at again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CharlotteDunois Thanks for the update, LGTM API-wise! 👍
What do you think about the below documentation suggestions?
@clue Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CharlotteDunois Nice, thank you for the quick update, now let's get this shipped! 🎉
@CharlotteDunois could you squash both commits together? Will merge afterwards 👍 |
This PR adds file read and write optimizations on the adapter level. Essentially it collapses open/read/close and open/write/close calls into one. Child Process is such an adapter which can use this optimization to reduce message passing & latency. Eio simulates the optimization by calling the necessary methods in sequence by itself.
Part of #46 & #46 (comment).
I want to add Eio has a very weird behaviour.