Change promise usage to recommendation #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
approved these changes
Oct 20, 2018
jsor
approved these changes
Oct 22, 2018
jsor
approved these changes
Oct 22, 2018
jsor
approved these changes
Oct 22, 2018
jsor
approved these changes
Oct 22, 2018
jsor
approved these changes
Oct 22, 2018
|
I'm not able to approve through the UI currently due to unicorns. So, oldschool |
for now.
1 similar comment
|
I'm not able to approve through the UI currently due to unicorns. So, oldschool |
jsor
approved these changes
Oct 22, 2018
jsor
approved these changes
Oct 22, 2018
WyriHaximus
approved these changes
Oct 22, 2018
WyriHaximus
approved these changes
Oct 22, 2018
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a split of the original PR #45 (the original PR shall stay open until completely done).
This PR changes the usage of promises inside this library to the recommendation listed on reactphp/promise. This PR also removes the unreachable code in
AbstractSyncAdapterand adds exceptions to rejected promises.The used promises in the tests are untouched, as they will be refactored anyway in a future PR.