-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pthreads adapter & refactors #45
Conversation
Right so there is a lot of good stuff in this PR and I'm really happy with that but it is basically to big to review in its current state. So I would prefer we break this up in separate PR's. Preferable starting with Now I appreciate the huge effort you put into all the fixes and the new |
This PR refactors the unit tests to be functional for the adapters, instead of mocking them, to test their implementation - not the expected stacktrace. This PR also changes some other things, such as:
new FulfilledPromise
->React\Promise\resolve
new RejectedPromise
->React\Promise\reject
count
anymore for the file descriptor - instead one will be generated using PHP7's random bytes APIls
has been made to use a promise, instead of a stream (made compatible to the interface)symlink
have been renamed to be not ambiguous anymoreCharlotteDunois/Phoebe
for pthreads pool with messaging and event looped workerThe PR commits will be squashed once review is positive. This PR includes and closes #46.