Improve performance of Loop
by avoiding unneeded method calls
#266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset improves performance of
Loop
slightly by avoiding unneeded method calls. Not the most significant improvement, but given the small changeset and how we plan to make the defaultLoop
more prominent in ReactPHP v3, I figured this change makes sense in either case:$ time php examples/91-benchmark-ticks.php 1000000 // old 0.83 // new 0.76
Builds on top of #245 and #229
See also https://github.com/orgs/reactphp/discussions/481