Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark legacy extensions as deprecated and minor documentation improvements #234

Merged
merged 1 commit into from
Jul 10, 2021

Conversation

SimonFrings
Copy link
Member

The maintenance for ExtLibeventLoop and ExtLibevLoop hasn't seen an update since 2013. It's time to move on.

@clue clue added this to the v1.2.0 milestone Jul 6, 2021
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thank you for looking into this, this deprecation notice is indeed long overdue (#40, #55, #62 and many others such as #230). Only added some minor remarks below, otherwise LGTM 👍

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@@ -12,10 +12,13 @@
use SplObjectStorage;

/**
* Deprecated since v1.2.0, use [`ExtEvLoop`](#extevloop) instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

src/ExtLibeventLoop.php Outdated Show resolved Hide resolved
@clue clue changed the title Mark extensions deprecated and minor docs improvement Mark legacy extensions as deprecated and minor documentation improvements Jul 6, 2021
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@clue clue requested a review from WyriHaximus July 10, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants