Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in docblock #233

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Fix typo in docblock #233

merged 1 commit into from
Jul 5, 2021

Conversation

nhedger
Copy link
Contributor

@nhedger nhedger commented Jul 5, 2021

Hi,

I caught a little typo in the docblock of the Loop::get method.

Have a nice day.

@clue clue added this to the v1.2.0 milestone Jul 5, 2021
WyriHaximus
WyriHaximus approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks 👍 !

@WyriHaximus WyriHaximus merged commit f52f930 into reactphp:master Jul 5, 2021
clue
clue approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhedger Thanks for spotting, changes LGTM! :shipit:

(Refs #226)

@nhedger nhedger deleted the patch-2 branch July 5, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clue clue clue approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nhedger @WyriHaximus @clue