Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub actions for continuous integration (CI) #38

Merged
merged 2 commits into from
Feb 1, 2021

Conversation

clue
Copy link
Member

@clue clue commented Feb 1, 2021

Bye bye Travis CI, you've served us well.

PHP 8 support requires some minor changes, so I'll file this as a separate PR once this is in.

Builds on top of reactphp/reactphp#442 and #37

Bye bye Travis CI, you've served us well.
@clue clue added this to the v1.6.0 milestone Feb 1, 2021
@clue
Copy link
Member Author

clue commented Feb 1, 2021

I've also updated this to include a minor code cleanup, removed any dead code and improved code coverage to 100% similar to reactphp/socket#236 :shipit:

@clue clue requested a review from WyriHaximus February 1, 2021 08:05
@WyriHaximus WyriHaximus merged commit 0a225a5 into reactphp:master Feb 1, 2021
@clue clue deleted the github-ci branch February 1, 2021 11:41
@SimonFrings SimonFrings mentioned this pull request Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants