Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test suite, add test namespaces, simplify test bootstrap logic and add forward compatibility with PHPUnit 7 and PHPUnit 6 #31

Merged
merged 2 commits into from
Jul 19, 2019
Merged

Improve test suite, add test namespaces, simplify test bootstrap logic and add forward compatibility with PHPUnit 7 and PHPUnit 6 #31

merged 2 commits into from
Jul 19, 2019

Conversation

clue
Copy link
Member

@clue clue commented Jul 18, 2019

Builds on top of #30

@clue clue added this to the v1.6.0 milestone Jul 18, 2019
@clue clue requested review from jsor and WyriHaximus July 18, 2019 22:29
WyriHaximus
WyriHaximus approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@WyriHaximus WyriHaximus merged commit d3e9d75 into reactphp:master Jul 19, 2019
@clue clue deleted the tests branch July 19, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@jsor jsor jsor approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clue @jsor @WyriHaximus