Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on Windows via Travis CI #71

Merged
merged 1 commit into from
Jan 13, 2019
Merged

Conversation

clue
Copy link
Member

@clue clue commented Jan 13, 2019

This PR adds Windows to the test matrix on Travis CI. Most of this project should work cross-platform, but we've added some Windows-specifics with #67, so we have reason to believe that tests help us ensure we do not introduce any regressions in the future.

Windows platform tests are currently allowed to fail, given how we've tried to add similar tests in the past (#21, #28 and #70) and also given that Windows platform support on Travis is currently considered "early release" (https://blog.travis-ci.com/2018-10-11-windows-early-release) and the test setup contains some workarounds. I consider this to be a first step and there's hope we can build on top of this in the future 👍

Credit where credit is due: Thanks @Lekensteyn for the detailed post in https://travis-ci.community/t/feedback-from-windows-integration-for-a-cmake-qt-c-python-perl-project/1706 which helped me immensely (spawning a powershell to read the updated PATH environment).

Builds on top of #67
Refs reactphp/stream#120 and reactphp/stream#112

@Lekensteyn
Copy link

You might want to add --no-progress to choco install, this reduces the amount of spam in the full log file. The download is still much smaller than Travis' timeout, so it's no problem to remain silent while downloading.

@clue
Copy link
Member Author

clue commented Jan 13, 2019

You might want to add --no-progress to choco install, this reduces the amount of spam in the full log file.

@Lekensteyn Thanks for chiming in, I agree that this might be an option. This output is part of the "installation" step and Travis does a decent job at collapsing this by default, so I don't think this is an issue currently.

@jsor jsor merged commit 9cceb08 into reactphp:master Jan 13, 2019
@clue clue deleted the windows-tests branch January 14, 2019 09:50
clue added a commit to clue-labs/reactphp-sqlite that referenced this pull request Apr 29, 2019
WyriHaximus added a commit to WyriHaximus-secret-labs/filesystem that referenced this pull request Oct 7, 2019
WyriHaximus added a commit to WyriHaximus-secret-labs/filesystem that referenced this pull request Oct 7, 2019
WyriHaximus added a commit to WyriHaximus-secret-labs/filesystem that referenced this pull request Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants