Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify backpressure overflow error message of interval #911

Merged
merged 1 commit into from
Oct 19, 2017

Conversation

simonbasle
Copy link
Member

This commit clarifies the javadoc and the error message propagated when
a Flux#interval ticks beyond downstream requests, resulting in an
OverflowException.

The message and javadoc make it more explicit that the error is coming
from the fact that interval doesn't really support backpressure, and
that the downstream should replenish requested amount before all the
ticks have been emitted.

This commit clarifies the javadoc and the error message propagated when
a `Flux#interval` ticks beyond downstream requests, resulting in an
OverflowException.

The message and javadoc make it more explicit that the error is coming
from the fact that interval doesn't really support backpressure, and
that the downstream should replenish requested amount before all the
ticks have been emitted.
@simonbasle simonbasle added the type/documentation A documentation update label Oct 19, 2017
@simonbasle simonbasle added this to the 3.1.1.RELEASE milestone Oct 19, 2017
@codecov-io
Copy link

codecov-io commented Oct 19, 2017

Codecov Report

Merging #911 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #911   +/-   ##
=========================================
  Coverage     83.67%   83.67%           
- Complexity     3312     3314    +2     
=========================================
  Files           323      323           
  Lines         26173    26173           
  Branches       4857     4857           
=========================================
  Hits          21901    21901           
- Misses         2817     2818    +1     
+ Partials       1455     1454    -1
Impacted Files Coverage Δ Complexity Δ
...ore/src/main/java/reactor/core/publisher/Flux.java 100% <ø> (ø) 473 <0> (ø) ⬇️
...main/java/reactor/core/publisher/FluxInterval.java 80.95% <100%> (+7.14%) 2 <0> (ø) ⬇️
.../java/reactor/core/publisher/FluxLimitRequest.java 94% <0%> (-4%) 5% <0%> (ø)
...ava/reactor/core/publisher/WorkQueueProcessor.java 69.06% <0%> (-1.28%) 19% <0%> (ø)
...ain/java/reactor/core/publisher/FluxPublishOn.java 87.84% <0%> (-0.42%) 5% <0%> (ø)
...c/main/java/reactor/core/publisher/FluxCreate.java 86.25% <0%> (-0.26%) 8% <0%> (ø)
...ava/reactor/core/publisher/EventLoopProcessor.java 78.68% <0%> (+0.54%) 50% <0%> (+1%) ⬆️
...main/java/reactor/core/publisher/FluxGenerate.java 70.37% <0%> (+0.61%) 7% <0%> (ø) ⬇️
...a/reactor/core/publisher/FluxBufferTimeOrSize.java 74.6% <0%> (+0.79%) 2% <0%> (ø) ⬇️
...rc/main/java/reactor/core/publisher/FluxRange.java 84.66% <0%> (+1.33%) 5% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fe37ef...8b2b32a. Read the comment docs.

@simonbasle
Copy link
Member Author

PR 911, CALL THE PO-LICE 👮 👮‍♀️ 🚔

@simonbasle simonbasle merged commit d16e2c9 into master Oct 19, 2017
@simonbasle simonbasle deleted the betterIntervalOverflowMessage branch October 19, 2017 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants