Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #898 Add Context testing features #901

Merged
merged 2 commits into from
Dec 18, 2017
Merged

fix #898 Add Context testing features #901

merged 2 commits into from
Dec 18, 2017

Conversation

simonbasle
Copy link
Member

  • set up an initial Context for a StepVerifier using options
  • set up expectations on the furthest reachable Context in the source
    chain

@simonbasle
fix #898 Add Context testing features
3270769 
 - set up an initial Context for a StepVerifier using options
 - set up expectations on the furthest reachable Context in the source
 chain
@simonbasle
Copy link
Member Author

@rstoyanchev @sdeleuze what do you think of the API? (see the two sets of added tests)

@simonbasle simonbasle added type/documentation A documentation update type/enhancement A general enhancement area/reactor-test This belongs to the reactor-test module labels Oct 10, 2017
@simonbasle simonbasle added this to the 3.1.1.RELEASE milestone Oct 10, 2017
@simonbasle simonbasle self-assigned this Oct 10, 2017
@smaldini
Copy link
Contributor

ping @rstoyanchev @sdeleuze should we move that to 3.1.2 to leave you time for further evaluation ? Also adding @poutsma -

@sdeleuze
Copy link
Contributor

If you want a review from me yes, I am not familiar enough with Context support yet to give a relevant advice.

@simonbasle
Copy link
Member Author

ping @rwinch: could you try that API out and see if from a Context-testing perspective it is missing something? I could produce a special "preview" snapshot of the branch if that helps.

@smaldini smaldini modified the milestones: 3.1.2.RELEASE, 3.1.3.RELEASE Nov 13, 2017
@simonbasle simonbasle added the for/fast-track Instructs the bot to fast track (internal) label Dec 18, 2017
reactorbot
reactorbot approved these changes Dec 18, 2017
View reviewed changes
Copy link

@reactorbot reactorbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast-track requested by @simonbasle

@simonbasle simonbasle merged commit 067c9f1 into master Dec 18, 2017
@simonbasle simonbasle deleted the 898-contextTesting branch December 18, 2017 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reactorbot reactorbot reactorbot approved these changes

@smaldini smaldini Awaiting requested review from smaldini

@sdeleuze sdeleuze Awaiting requested review from sdeleuze

@rstoyanchev rstoyanchev Awaiting requested review from rstoyanchev

Assignees

@simonbasle simonbasle

Labels
area/reactor-test This belongs to the reactor-test module for/fast-track Instructs the bot to fast track (internal) type/documentation A documentation update type/enhancement A general enhancement
Projects
None yet
Milestone
3.1.3.RELEASE
Development

Successfully merging this pull request may close these issues.
4 participants
@simonbasle @smaldini @sdeleuze @reactorbot