Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert generic type arguments nullability #875

Merged
merged 3 commits into from
Sep 21, 2017
Merged

Conversation

sdeleuze
Copy link
Contributor

See Kotlin/KEEP#79 (comment) for more details. I will commit the documentation tomorrow.

This commit introduces following changes:
 - It adds @nonnull and @nullable annotations which allows to apply
null-safety semantics on a specific type like JSR 305 but could also
allow in the future  to target generic type arguments.
 - @NonNullApi does not apply to ElementType.TYPE anymore
@codecov-io
Copy link

Codecov Report

Merging #875 into master will decrease coverage by 0.02%.
The diff coverage is 73.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #875      +/-   ##
============================================
- Coverage     83.54%   83.52%   -0.03%     
- Complexity     3277     3278       +1     
============================================
  Files           319      319              
  Lines         26052    26052              
  Branches       4840     4840              
============================================
- Hits          21766    21759       -7     
- Misses         2827     2833       +6     
- Partials       1459     1460       +1
Impacted Files Coverage Δ Complexity Δ
...actor-core/src/main/java/reactor/util/Loggers.java 59.42% <ø> (ø) 8 <0> (ø) ⬇️
...re/src/main/java/reactor/util/function/Tuple4.java 95% <ø> (ø) 13 <0> (ø) ⬇️
...ava/reactor/core/publisher/FluxHandleFuseable.java 77.4% <ø> (ø) 3 <0> (ø) ⬇️
...ain/java/reactor/core/publisher/FluxRetryWhen.java 92.1% <ø> (ø) 4 <0> (ø) ⬇️
...in/java/reactor/core/publisher/MonoIgnoreThen.java 75.6% <ø> (ø) 3 <0> (ø) ⬇️
...c/main/java/reactor/core/publisher/SignalPeek.java 50% <ø> (ø) 1 <0> (ø) ⬇️
...java/reactor/core/publisher/FluxSampleTimeout.java 81.45% <ø> (ø) 2 <0> (ø) ⬇️
...re/src/main/java/reactor/util/function/Tuple5.java 95.23% <ø> (ø) 14 <0> (ø) ⬇️
.../java/reactor/core/publisher/ParallelFluxName.java 96.77% <ø> (ø) 14 <0> (ø) ⬇️
...re/src/main/java/reactor/util/function/Tuple3.java 100% <ø> (ø) 13 <0> (ø) ⬇️
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f6181...3b41ffe. Read the comment docs.

@smaldini smaldini merged commit 1798dd9 into reactor:master Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants