-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local error consumer hooks support #830
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaldini
added
warn/api-change
Breaking change with compilation errors
type/enhancement
A general enhancement
labels
Aug 31, 2017
smaldini
changed the title
Contextualize Operators.onErrorDropped and onNextDropped
Add local error consumer hooks
Aug 31, 2017
Codecov Report
@@ Coverage Diff @@
## master #830 +/- ##
============================================
- Coverage 83.07% 83.04% -0.03%
- Complexity 3172 3184 +12
============================================
Files 316 316
Lines 25526 25677 +151
Branches 4771 4774 +3
============================================
+ Hits 21206 21324 +118
- Misses 2864 2898 +34
+ Partials 1456 1455 -1
Continue to review full report at Codecov.
|
- remove unused Operators.onErrorDropped(error, supp) - add few missing Operators.onNextDropped
- fix UnicastProcessor currentContext
or are "multicast" cases mark as such for future refactor
…eratorError/onRejectedExecution
simonbasle
force-pushed
the
contextualized-hooks
branch
from
September 4, 2017 19:54
0e5457a
to
df21ff9
Compare
this works by replacing the onOperatorError hook in the context passed when calling Operators.onOperatorError from onRejectedExecution (if there is a local hook for the REE-specific key).
smaldini
changed the title
Add local error consumer hooks
Add local error consumer hooks support
Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #435