Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local error consumer hooks support #830

Merged
merged 5 commits into from
Sep 5, 2017
Merged

Conversation

smaldini
Copy link
Contributor

@smaldini smaldini commented Aug 31, 2017

Related to #435

  • contextualize Operators.onErrorDropped and onNextDropped
  • remove unused Operators.onErrorDropped(error, supp)
  • add few missing Operators.onNextDropped
  • contextualize Operators.onOperatorsError
  • contextualize Operators.onRejectedExecution

@smaldini smaldini added warn/api-change Breaking change with compilation errors type/enhancement A general enhancement labels Aug 31, 2017
@smaldini smaldini added this to the 3.1.0.RC1 milestone Aug 31, 2017
@smaldini smaldini changed the title Contextualize Operators.onErrorDropped and onNextDropped Add local error consumer hooks Aug 31, 2017
@codecov-io
Copy link

codecov-io commented Aug 31, 2017

Codecov Report

Merging #830 into master will decrease coverage by 0.02%.
The diff coverage is 57.04%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #830      +/-   ##
============================================
- Coverage     83.07%   83.04%   -0.03%     
- Complexity     3172     3184      +12     
============================================
  Files           316      316              
  Lines         25526    25677     +151     
  Branches       4771     4774       +3     
============================================
+ Hits          21206    21324     +118     
- Misses         2864     2898      +34     
+ Partials       1456     1455       -1
Impacted Files Coverage Δ Complexity Δ
...ain/java/reactor/core/publisher/MonoDoFinally.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...ore/src/main/java/reactor/core/publisher/Mono.java 95.07% <ø> (ø) 228 <0> (ø) ⬇️
...ore/src/main/java/reactor/core/publisher/Flux.java 100% <ø> (ø) 466 <0> (ø) ⬇️
.../reactor/core/publisher/FluxDoFinallyFuseable.java 100% <ø> (ø) 2 <0> (ø) ⬇️
.../reactor/core/publisher/MonoDoFinallyFuseable.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...in/java/reactor/core/publisher/FluxWindowWhen.java 74.33% <0%> (-0.34%) 2 <0> (ø)
...main/java/reactor/core/publisher/FluxInterval.java 76.19% <0%> (-1.86%) 2 <0> (ø)
...ava/reactor/core/publisher/FluxWindowBoundary.java 80.57% <0%> (ø) 2 <0> (ø) ⬇️
.../java/reactor/core/publisher/StrictSubscriber.java 59.7% <0%> (ø) 15 <0> (ø) ⬇️
.../reactor/core/publisher/FluxDelaySubscription.java 75.86% <0%> (ø) 3 <0> (ø) ⬇️
... and 159 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aff262...25aef6c. Read the comment docs.

@simonbasle simonbasle mentioned this pull request Sep 4, 2017
3 tasks
@simonbasle
Copy link
Member

@smaldini I opened #844 for the follow-ups, focusing on calling Operators hooks with a Context and looking into that Context for local hooks for now.

Stephane Maldini and others added 4 commits September 4, 2017 21:53
- remove unused Operators.onErrorDropped(error, supp)
- add few missing Operators.onNextDropped
or are "multicast" cases mark as such for future refactor
this works by replacing the onOperatorError hook in the context passed
when calling Operators.onOperatorError from onRejectedExecution (if
there is a local hook for the REE-specific key).
@smaldini smaldini merged commit ac8f299 into master Sep 5, 2017
@smaldini smaldini deleted the contextualized-hooks branch September 5, 2017 15:33
@smaldini smaldini changed the title Add local error consumer hooks Add local error consumer hooks support Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement warn/api-change Breaking change with compilation errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants