Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #730 Use Flux instead of GroupedFlux for FluxWindowPredicate #759

Merged
merged 2 commits into from
Jul 27, 2017

Conversation

rajinisivaram
Copy link
Contributor

No description provided.

@smaldini smaldini added this to the 3.1.0.RC1 milestone Jul 26, 2017
@smaldini smaldini added the warn/api-change Breaking change with compilation errors label Jul 26, 2017
@@ -847,7 +837,7 @@ public Object scanUnsafe(Attr key) {

@Override
public String toString() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can safely remove that toString

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smaldini Done, thanks.

@codecov-io
Copy link

codecov-io commented Jul 26, 2017

Codecov Report

Merging #759 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #759      +/-   ##
============================================
- Coverage     82.23%   82.21%   -0.02%     
- Complexity     2936     2937       +1     
============================================
  Files           306      306              
  Lines         25297    25294       -3     
  Branches       4788     4788              
============================================
- Hits          20802    20795       -7     
- Misses         2988     2989       +1     
- Partials       1507     1510       +3
Impacted Files Coverage Δ Complexity Δ
...ore/src/main/java/reactor/core/publisher/Flux.java 100% <ø> (ø) 465 <0> (ø) ⬇️
...va/reactor/core/publisher/FluxWindowPredicate.java 90.1% <100%> (-0.09%) 3 <0> (ø)
...rc/main/java/reactor/core/publisher/FluxRange.java 83.33% <0%> (-1.34%) 5% <0%> (ø)
...ava/reactor/core/publisher/WorkQueueProcessor.java 67.22% <0%> (-0.85%) 19% <0%> (ø)
...actor/core/scheduler/ExecutorServiceScheduler.java 80.26% <0%> (-0.66%) 15% <0%> (ø)
...eactor/core/publisher/ParallelMergeSequential.java 76.53% <0%> (-0.52%) 3% <0%> (ø)
.../main/java/reactor/core/publisher/FluxFlatMap.java 94.92% <0%> (-0.21%) 13% <0%> (ø)
...ava/reactor/core/publisher/EventLoopProcessor.java 75.8% <0%> (ø) 49% <0%> (ø) ⬇️
...rc/main/java/reactor/core/publisher/Operators.java 69.86% <0%> (ø) 68% <0%> (ø) ⬇️
...ain/java/reactor/core/publisher/FluxPublishOn.java 86.15% <0%> (+0.2%) 5% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c2c645...e6a2253. Read the comment docs.

@simonbasle simonbasle merged commit e01c738 into reactor:master Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
warn/api-change Breaking change with compilation errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants