Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3835] Fix SynchronousSink javadoc #3838

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

ilya-ulyanov
Copy link
Contributor

This PR is to apply javadoc fix for SynchronousSink interface

Documentation Issue

The javadoc for the SynchronousSink says:
"... You can FluxSink or MonoSink based generators for these situations."

Improvement Suggestion

The above should be rephrased by adding a verb, for instance - "use", so it becomes:
"... You can use FluxSink or MonoSink based generators for these situations."

closes #3835

@ilya-ulyanov ilya-ulyanov requested a review from a team as a code owner July 3, 2024 07:17
@chemicL chemicL added the type/documentation A documentation update label Jul 3, 2024
@chemicL chemicL added this to the 3.7.0-M4 milestone Jul 3, 2024
@chemicL chemicL merged commit af6f417 into reactor:main Jul 4, 2024
7 checks passed
@chemicL
Copy link
Member

chemicL commented Jul 4, 2024

Thanks for the contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SynchronousSink - verb is missing in javadoc
2 participants