Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1078 - do not throw dropped errors and callback hook #1085

Merged
merged 1 commit into from
Feb 20, 2018

Conversation

smaldini
Copy link
Contributor

@smaldini smaldini commented Feb 19, 2018

  • add missing onNextDropped hook in Mono.create

@smaldini smaldini added the type/bug A general bug label Feb 19, 2018
@smaldini smaldini added this to the 3.1.5.RELEASE milestone Feb 19, 2018
add missing onNextDropped hook in Mono.create
@smaldini smaldini force-pushed the 1078-doNotRethrowMonoFluxCreate branch from db1ec5c to 793d517 Compare February 19, 2018 21:29
@codecov-io
Copy link

codecov-io commented Feb 19, 2018

Codecov Report

Merging #1085 into master will increase coverage by 0.1%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #1085     +/-   ##
===========================================
+ Coverage     83.65%   83.75%   +0.1%     
- Complexity     3541     3548      +7     
===========================================
  Files           334      334             
  Lines         27675    27676      +1     
  Branches       5182     5182             
===========================================
+ Hits          23152    23181     +29     
+ Misses         2959     2945     -14     
+ Partials       1564     1550     -14
Impacted Files Coverage Δ Complexity Δ
...c/main/java/reactor/core/publisher/FluxCreate.java 85.82% <0%> (+0.51%) 8 <0> (ø) ⬇️
...c/main/java/reactor/core/publisher/MonoCreate.java 76.14% <100%> (-0.71%) 2 <0> (ø)
...r-core/src/main/java/reactor/core/Disposables.java 89.18% <0%> (-0.46%) 20% <0%> (ø)
...ava/reactor/core/publisher/WorkQueueProcessor.java 69.65% <0%> (-0.43%) 19% <0%> (ø)
...ain/java/reactor/core/publisher/FluxPublishOn.java 86.9% <0%> (+0.2%) 6% <0%> (ø) ⬇️
...rc/main/java/reactor/core/publisher/Operators.java 72.68% <0%> (+0.34%) 94% <0%> (+1%) ⬆️
...java/reactor/core/publisher/FluxBufferTimeout.java 72.72% <0%> (+0.69%) 3% <0%> (ø) ⬇️
...main/java/reactor/core/publisher/SignalLogger.java 72.3% <0%> (+0.76%) 66% <0%> (+1%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db1126a...793d517. Read the comment docs.

@simonbasle simonbasle merged commit db244e0 into master Feb 20, 2018
@simonbasle simonbasle deleted the 1078-doNotRethrowMonoFluxCreate branch February 20, 2018 14:16
simonbasle pushed a commit that referenced this pull request Feb 26, 2018
Flux.create and Mono.create don't use `onErrorDropped` anymore,
preventing throws when the default behaviour is still in place. Instead,
they call `onOperatorError` without signalling the resulting Throwable.

This has a saner default of "swallowing" the exception rather than
throwing it out of the reactive chain and causing problems. It can still
be locally customized using the `Context` undocumented key approach.

Also added a missing onNextDropped hook in Mono.create.

This is a backport of #1085 (commit db244e0), as tracked in #1083
@smaldini smaldini modified the milestones: 3.1.5.RELEASE, 3.2.0.RELEASE Feb 26, 2018
@simonbasle simonbasle added status/backported-3.1 backported in previous generation line (3.1) and removed need-backport-3.1 labels Mar 5, 2018
@simonbasle simonbasle modified the milestones: 3.2.0.RELEASE, 3.2.0.M2 May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/backported-3.1 backported in previous generation line (3.1) type/bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants