Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map nullable returns types to non-nullable Monos. #1062

Merged
merged 1 commit into from
Feb 11, 2018

Conversation

sbuettner
Copy link

@sbuettner sbuettner commented Feb 7, 2018

Map nullable returns types to non-nullable Monos and only allow non-nullable Fluxes. This avoids handling nulls inside Mono operations like map when the Mono was created from a nullable type like String? for example.

Only allow non-nullable Fluxes.
@codecov-io
Copy link

Codecov Report

Merging #1062 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1062      +/-   ##
============================================
- Coverage     83.82%   83.77%   -0.05%     
+ Complexity     3464     3463       -1     
============================================
  Files           333      333              
  Lines         27135    27135              
  Branches       5030     5030              
============================================
- Hits          22746    22733      -13     
- Misses         2908     2912       +4     
- Partials       1481     1490       +9
Impacted Files Coverage Δ Complexity Δ
...in/kotlin/reactor/core/publisher/MonoExtensions.kt 83.33% <100%> (ø) 0 <0> (ø) ⬇️
...in/kotlin/reactor/core/publisher/FluxExtensions.kt 91.66% <100%> (ø) 0 <0> (ø) ⬇️
...rc/main/java/reactor/core/publisher/MonoDelay.java 73.33% <0%> (-8.89%) 2% <0%> (ø)
.../java/reactor/util/concurrent/MpscLinkedQueue.java 81.57% <0%> (-7.9%) 16% <0%> (-2%)
...c/main/java/reactor/core/scheduler/WorkerTask.java 79.24% <0%> (-3.78%) 19% <0%> (ø)
...ain/java/reactor/util/concurrent/WaitStrategy.java 51.21% <0%> (-1.63%) 11% <0%> (ø)
...in/java/reactor/core/publisher/MonoDelayUntil.java 79.62% <0%> (-0.93%) 4% <0%> (ø)
...java/reactor/core/publisher/FluxBufferTimeout.java 72.85% <0%> (-0.72%) 2% <0%> (ø)
...ain/java/reactor/core/publisher/FluxPublishOn.java 87.21% <0%> (-0.63%) 5% <0%> (ø)
...c/main/java/reactor/core/publisher/FluxExpand.java 92% <0%> (-0.45%) 3% <0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4b14b5...10081b0. Read the comment docs.

@smaldini smaldini added this to the 3.1.4.RELEASE milestone Feb 10, 2018
@smaldini smaldini merged commit f88ea67 into reactor:master Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants