Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flux#windowWhen does not remove terminated windows (leak) #975

Closed
smaldini opened this issue Dec 1, 2017 · 0 comments
Closed

Flux#windowWhen does not remove terminated windows (leak) #975

smaldini opened this issue Dec 1, 2017 · 0 comments
Labels
type/bug A general bug
Milestone
3.1.3.RELEASE

Comments

@smaldini
Copy link
Contributor

smaldini commented Dec 1, 2017

Windows with selector (window(timestamp, timeshift) and windowWhen currently suffer a window leak: the windows set keeps growing.
Would be appropriate to review the impl specially now we have access to CompositeDisposable.
@smaldini smaldini added the type/bug A general bug label Dec 1, 2017
@smaldini smaldini added this to the 3.1.3.RELEASE milestone Dec 1, 2017
simonbasle added a commit that referenced this issue Dec 13, 2017
@simonbasle
fix #975 Prevent windowWhen from retaining windows
b4e385c
@simonbasle simonbasle mentioned this issue Dec 13, 2017
Closed
@simonbasle simonbasle mentioned this issue Jan 4, 2018
Closed
simonbasle added a commit that referenced this issue Jan 6, 2018
@simonbasle
fix #975 windowWhen leaks by changing FluxWindowWhen implementation
a2bd4ae 
This commit brings the windowWhen implementation in line with that of
RxJava, fixing the fact that drained windows were retained until main
sequence completion in the previous implementation.
simonbasle added a commit that referenced this issue Jan 9, 2018
@simonbasle
fix #975 windowWhen reimplementation stops retaining windows
63c7962 
This commit fixes `windowWhen` leaks by changing `FluxWindowWhen`
implementation, bringing it in line with that of RxJava (drained windows
were retained until main sequence completion previously).

Added padding test of QueueDrainSubscriber using the Java Object Layout
(JOL) tool.
@jldec jldec mentioned this issue Jan 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug A general bug
Projects
None yet
Milestone
3.1.3.RELEASE
Development

No branches or pull requests
1 participant
@smaldini