Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParallelFlux#composeGroup should conserve parallelism and prefetch #968

Closed
dfeist opened this issue Nov 29, 2017 · 1 comment
Closed

ParallelFlux#composeGroup should conserve parallelism and prefetch #968

dfeist opened this issue Nov 29, 2017 · 1 comment
Assignees
@simonbasle
Labels
good first issue Ideal for a new contributor, we'll help type/bug A general bug
Milestone
3.1.3.RELEASE

Comments

@dfeist
Copy link
Contributor

dfeist commented Nov 29, 2017

Currently, it reverts back to default due to its use of ParallelFlux.from()

Should also check if there are any other ParallelFlux operators that this applies to
@simonbasle simonbasle added the good first issue Ideal for a new contributor, we'll help label Nov 29, 2017
@simonbasle
Copy link
Member

the from can be called with parallelism() to maintain the same parallelism (which should otherwise be propagated correctly by other parallel operators).
It should be possible to maintain the prefetch as well IF getPrefetch() doesn't return -1 (in which case the fallback would be to use from(parallelism) overload).

@simonbasle simonbasle added the type/bug A general bug label Nov 29, 2017
@simonbasle simonbasle added this to the 3.1.3.RELEASE milestone Nov 29, 2017
@simonbasle simonbasle self-assigned this Nov 30, 2017
simonbasle added a commit that referenced this issue Dec 1, 2017
@simonbasle
fix #968 ParallelFlux#composeGroup maintains parallelism()
40421ba 
(and prefetch as well if relevant)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonbasle simonbasle

Labels
good first issue Ideal for a new contributor, we'll help type/bug A general bug
Projects
None yet
Milestone
3.1.3.RELEASE
Development

No branches or pull requests
2 participants
@dfeist @simonbasle