Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc for some versions is missing from the website #3794

Closed
dkhalanskyjb opened this issue Apr 22, 2024 · 3 comments
Closed

Javadoc for some versions is missing from the website #3794

dkhalanskyjb opened this issue Apr 22, 2024 · 3 comments
Labels
status/declined We feel we shouldn't currently apply this change/suggestion type/documentation A documentation update

Comments

@dkhalanskyjb
Copy link

dkhalanskyjb commented Apr 22, 2024

Documentation Issue

https://projectreactor.io/docs/core lists most versions, but not all of them. For example, versions 3.4.0-3.4.4 are not there, even though even 3.4.0-RC2 is listed.

Improvement Suggestion

Publish documentation for the missing releases.

Additional context

In kotlinx-coroutines, we would like to link to the entities we use, using the documentation of the release that's our dependency, but links like https://projectreactor.io/docs/core/3.4.1/api/reactor/core/publisher/MonoSink.html are 404.

@dkhalanskyjb dkhalanskyjb added the type/documentation A documentation update label Apr 22, 2024
@chemicL
Copy link
Member

chemicL commented Apr 22, 2024

Hey, @dkhalanskyjb !

Unfortunately, there is nothing we can do at this point. Since 3.4.5 reactor-core switched to using Sonatype's s01 repository for javadoc jars. Therefore, versions lower than that won't be available. Milestone and RC releases are fetching from Spring's artifact repository so it's a different case.

Bear in mind that 3.4.x and 3.5.x are going out of OSS support by the end of August this year.

@chemicL chemicL closed this as not planned Won't fix, can't repro, duplicate, stale Apr 22, 2024
@chemicL chemicL added the status/declined We feel we shouldn't currently apply this change/suggestion label Apr 22, 2024
@dkhalanskyjb
Copy link
Author

@chemicL, sorry, I don't get it. What's stopping you from checking out the corresponding tag in this repository, building the documentation, and uploading it to the website?

@chemicL
Copy link
Member

chemicL commented Apr 22, 2024

@dkhalanskyjb we are not uploading the documentation anywhere. We're using Sonatype's API to serve the javadocs from the jar that they host. Feel free to grab the javadoc jars from Maven Central and host them the same way https://javadoc.dev/ or https://javadocs.dev/ does or just use their service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/declined We feel we shouldn't currently apply this change/suggestion type/documentation A documentation update
Projects
None yet
Development

No branches or pull requests

2 participants