Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not call error callback in afterTerminate callback failure in FluxPeek #270

Closed
simonbasle opened this issue Nov 25, 2016 · 0 comments
Closed

Do not call error callback in afterTerminate callback failure in FluxPeek #270

simonbasle opened this issue Nov 25, 2016 · 0 comments
Labels
type/enhancement A general enhancement warn/api-change Breaking change with compilation errors
Milestone
3.1.0.M1

Comments

@simonbasle
Copy link
Member

FluxPeek and FluxPeekFuseable all invoke the error callback if afterTerminate callback fails. This behavior should be phased out.
@simonbasle simonbasle added warn/api-change Breaking change with compilation errors type/enhancement A general enhancement labels Nov 25, 2016
@simonbasle simonbasle added this to the 3.1.0.RELEASE milestone Nov 25, 2016
simonbasle added a commit that referenced this issue Dec 13, 2016
@simonbasle
fix #289 Split Signal into immutable and mutable version
4b469be 
Signal is now an abstract class, and the default implementation is still
the immutable one. Introduce a mutable version for onNext signals that
can be used to limit the number of created instances in advanced cases,
here used for doOnEach.

A new operator, `FluxPeekStateful`, is used. It peeks into a sequence
while also passing around an arbitrary state object, per subscriber.

Note that FluxPeekStateful already doesn't call onError upon an
afterTerminate callback failure (#270).
@smaldini smaldini modified the milestones: 3.1.0.M1, 3.1.0.RELEASE Apr 20, 2017
simonbasle added a commit that referenced this issue Apr 25, 2017
@simonbasle
fix #270 Don't call onError if doAfterTerminate callback fails
ca38da2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement A general enhancement warn/api-change Breaking change with compilation errors
Projects
None yet
Milestone
3.1.0.M1
Development

No branches or pull requests
2 participants
@smaldini @simonbasle