doOnEach not executed

[jmilkiewicz]

As i started introducing MDC logging (according to https://simonbasle.github.io/2018/02/contextual-logging-with-reactor-context-and-mdc/)
i heavily rely on doOnEach for logging.

I started to experience that sometimes doOnEach is not executed.
At least this is what i observe in tests.

To reproduce the behavior please take a look at https://github.com/jmilkiewicz/doOnEachBug/blob/master/src/test/java/DoOneEachTest.java

The test shows that doOnEach (the one after map ) is simply not executed at all !
If i uncomment doOnEach (before map ) than everything works as expected !
Seems like map is spoiling something 😉

I also tried to build chain with 2 subsequent doOnEach (after map )

.map(x -> processMe(x)) 
.doOnEach(sig -> System.out.println("AFTERMap " + sig))
.doOnEach(sig -> {throw new RuntimeException("expected");})

but none of doOnEach is executed

I experience this behavior in Bismuth-SR5 ( 3.1.3.RELEASE)
If i downgrade to Bismuth-RELEASE (3.1.0.RELEASE)
than everything works fine and doOnEach is executed as expected

java version "1.8.0_60"
Java(TM) SE Runtime Environment (build 1.8.0_60-b27)
Java HotSpot(TM) 64-Bit Server VM (build 25.60-b23, mixed mode)

[smaldini]

Thanks for the detailed report and good catch!
I added your test to master and it is working, you can try 3.1.4.BUILD-SNAPSHOT.
It has been already fixed by this a5647fc

[jmilkiewicz]

Hey

seems to work in 3.1.4.BUILD-SNAPSHOT.
BTW: can you tell me when 3.1.4 will be released ?

[smaldini]

We're aiming for Thursday next week (+/- 1 day)

[simonbasle]

I'll mention issue #1056 on my blog post in the meantime ;)